node-api: avoid calling virtual methods in base's dtor #44424
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Review requested:
|
Member
|
Maybe I'm missing something but |
Member
Author
|
bnoordhuis
approved these changes
Aug 28, 2022
src/js_native_api_v8.h
Outdated
| virtual ~napi_env__() { FinalizeAll(); } | ||
| v8::Isolate* const isolate; // Shortcut for context()->GetIsolate() | ||
| v8impl::Persistent<v8::Context> context_persistent; | ||
| virtual ~napi_env__() = default; |
Member
There was a problem hiding this comment.
Maybe try if you can make the constructor protected, to avoid callers deleting it without proper cleanup.
Member
Author
There was a problem hiding this comment.
Make sense to me. Thank you for the suggestion! Updated.
Derived classes' fields are already destroyed if the virtual methods are invoked in the base class's destructor. It is not safe to call virtual methods in base's dtor.
e2d1c39 to
dd48302
Compare
Collaborator
jasnell
approved these changes
Aug 28, 2022
JungMinu
approved these changes
Aug 30, 2022
30 tasks
Collaborator
Collaborator
Collaborator
|
Landed in ad3c7bc |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Derived classes' fields are already destroyed if the virtual methods are
invoked in the base class's destructor. It is not safe to call virtual
methods in base's dtor.